RFR: 8326609: New AES implementation with updates specified in FIPS 197 [v2]

[Shawn M Emery]

On Tue, 14 Oct 2025 19:59:04 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:

>> Shawn M Emery has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add vmIntrinsics.hpp updates
>
> src/java.base/share/classes/com/sun/crypto/provider/AES_Crypt.java line 43:
> 
>> 41:  * https://www.internationaljournalcorner.com/index.php/ijird_ojs/article/view/134688
>> 42:  */
>> 43: public final class AESCrypt extends SymmetricCipher {
> 
> Should the class be named `AES_Crypt` instead?

Yes, you're right.  I'm not sure how it reverted back to AESCrypt.  Fixed.

> src/java.base/share/classes/com/sun/crypto/provider/AES_Crypt.java line 1408:
> 
>> 1406:      */
>> 1407:     public void encryptBlock(byte[] plain, int pOff, byte[] cipher, int cOff) {
>> 1408:         implEncryptBlock(plain, pOff, cipher, cOff);
> 
> There are no bounds checks around intrinsic methods. Previous implementation has a comment stating that the checks are placed in caller code (for performance reasons) and declared the methods package-private. It makes sense either to introduce bounds checks here or keep the wrappers package-private.

Good catch, I will leave it as package-private then.  Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27807#discussion_r2431157744
PR Review Comment: https://git.openjdk.org/jdk/pull/27807#discussion_r2431158083