RFR: 8369804: TestGenerators.java fails with IllegalArgumentException: bound must be greater than origin [v2]

Tobias Hartmann thartmann at openjdk.org
Wed Oct 15 09:24:55 UTC 2025


On Wed, 15 Oct 2025 09:21:34 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> We sample two floats, assuming we would get two different results. But ever so rarely, we get the same values, and the test fails.
>> 
>> So now, I sample with retry. And also improve the error reporting, throwing an exception on generator construction rather than sampling from the generator.
>
> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Apply suggestions from code review

Thanks for quickly fixing this, looks good to me!

-------------

Marked as reviewed by thartmann (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/27816#pullrequestreview-3339308027


More information about the hotspot-compiler-dev mailing list