RFR: 8369804: TestGenerators.java fails with IllegalArgumentException: bound must be greater than origin [v2]

[Emanuel Peter]

On Wed, 15 Oct 2025 09:21:34 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> We sample two floats, assuming we would get two different results. But ever so rarely, we get the same values, and the test fails.
>> 
>> So now, I sample with retry. And also improve the error reporting, throwing an exception on generator construction rather than sampling from the generator.
>
> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Apply suggestions from code review

test/hotspot/jtreg/testlibrary_tests/generators/tests/TestGenerators.java line 596:

> 594:         for (int j = 0; j < 500; j++) {
> 595:             float lo = 1, hi = 0;
> 596:             // Failur of a single round is very rare, repeated failure even rarer.

Suggestion:

            // Failure of a single round is very rare, repeated failure even rarer.

test/hotspot/jtreg/testlibrary_tests/generators/tests/TestGenerators.java line 613:

> 611:         for (int j = 0; j < 500; j++) {
> 612:             double lo = 1, hi = 0;
> 613:             // Failur of a single round is very rare, repeated failure even rarer.

Suggestion:

            // Failure of a single round is very rare, repeated failure even rarer.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27816#discussion_r2431793215
PR Review Comment: https://git.openjdk.org/jdk/pull/27816#discussion_r2431793881