RFR: 8369573: Add missing compile commands help documentation for the signature part of method patterns
Tobias Hartmann
thartmann at openjdk.org
Thu Oct 16 06:34:00 UTC 2025
On Wed, 15 Oct 2025 08:17:46 GMT, Daniel Lundén <dlunden at openjdk.org> wrote:
> The documentation of the signature part of method patterns in `java -XX:CompileCommand=help` is missing. We should add it.
>
> ### Changeset
> - Improve the documentation of signatures in `java -XX:CompileCommand=help`.
>
> ### Testing
>
> - [GitHub Actions](https://github.com/dlunde/jdk/actions/runs/18500483034)
> - `tier1` and HotSpot parts of `tier2` and `tier3` (and additional Oracle-internal testing) on Windows x64, Linux x64, Linux aarch64, macOS x64, and macOS aarch64.
Looks good to me. I'm fine with using "signature" but I don't have a strong opinion.
src/hotspot/share/compiler/compilerOracle.cpp line 639:
> 637: tty->print_cr(" package/Class.method,(Lpackage/Parameter;)Lpackage/Return;");
> 638: tty->cr();
> 639: tty->print_cr("The <class> and <method> accept leading and trailing *'s for wildcard");
Suggestion:
tty->print_cr("The <class> and <method> accept leading and trailing '*' wildcards");
-------------
Marked as reviewed by thartmann (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/27818#pullrequestreview-3343247716
PR Review Comment: https://git.openjdk.org/jdk/pull/27818#discussion_r2434724926
More information about the hotspot-compiler-dev
mailing list