RFR: 8369573: Add missing compile commands help documentation for the signature part of method patterns

Roberto Castañeda Lozano rcastanedalo at openjdk.org
Thu Oct 16 07:37:13 UTC 2025


On Wed, 15 Oct 2025 15:19:42 GMT, Daniel Lundén <dlunden at openjdk.org> wrote:

> > Thanks for doing this, Daniel! Would it be possible to use the more precise term "method descriptor" instead of "signature" in the help message?
> 
> Yes, I agree and did consider this as well after consulting the JVM spec. I let "signature" remain as that is what is used currently and also seems to be the terminology used in the code. I'll wait a bit for more comments before committing to changing it.

Thanks! To elaborate a bit further on my proposed change, I think using "method descriptor" all trough the help message is a bit clearer because 1) it removes one term (and hence the need to explain the connection between "signature" and "method descriptor" in https://github.com/openjdk/jdk/pull/27818/files#diff-80400270ae0db6c776055d9fd5ab13b909d2db8a5dde8df46063cb54b1c3c0d3R644-R646) and 2) in the context of Java, a "signature" tends to refer to the parameter types only, excluding return type (see e.g. https://en.wikipedia.org/wiki/Type_signature#Java_2 or https://docs.oracle.com/javase/tutorial/java/javaOO/methods.html).

-------------

PR Comment: https://git.openjdk.org/jdk/pull/27818#issuecomment-3409570437


More information about the hotspot-compiler-dev mailing list