RFR: 8369232: testlibrary_tests/ir_framework/tests/TestScenariosCrossProduct.java timed out [v4]
Christian Hagedorn
chagedorn at openjdk.org
Thu Oct 16 07:53:08 UTC 2025
On Wed, 15 Oct 2025 12:47:36 GMT, Damon Fenacci <dfenacci at openjdk.org> wrote:
>> Christian Hagedorn has updated the pull request incrementally with one additional commit since the last revision:
>>
>> review Emanuel
>
> test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestScenariosCrossProduct.java line 337:
>
>> 335: Asserts.assertTrue(stdErr.contains("Scenario flags: [-XX:-UseNewCode, -XX:-UseNewCode2]"));
>> 336: Asserts.assertTrue(stdErr.contains("Scenario flags: [-XX:+UseNewCode, -XX:-UseNewCode2]"));
>> 337: Asserts.assertTrue(stdErr.contains("Scenario flags: [-XX:-UseNewCode, -XX:+UseNewCode2]"));
>
> This might be partially redundant with the full stop in the first assert above but maybe it would be worth checking that we don't have any additional "Scenario flags:..." string.
Good idea, I added a scenario count.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27672#discussion_r2434925355
More information about the hotspot-compiler-dev
mailing list