RFR: 8368205: [TESTBUG] VectorMaskCompareNotTest.java crashes when MaxVectorSize=8 [v2]

[Martin Doerr]

On Fri, 17 Oct 2025 01:21:59 GMT, erifan <duke at openjdk.org> wrote:

>> test/hotspot/jtreg/compiler/vectorapi/VectorMaskCompareNotTest.java line 38:
>> 
>>> 36:  * @summary test combining vector not operation with compare
>>> 37:  * @modules jdk.incubator.vector
>>> 38:  * @requires vm.opt.final.MaxVectorSize == "null" | vm.opt.final.MaxVectorSize >= 16
>> 
>> Should be
>> Suggestion:
>> 
>>  * @requires vm.opt.final.MaxVectorSize == "null" & vm.opt.final.MaxVectorSize >= 16
>> 
>> 
>> or
>> Suggestion:
>> 
>>  * @requires  vm.compiler2.enabled & vm.opt.final.MaxVectorSize >= 16
>> 
>> ?
>> 
>> Assume this test is run with another compiler (like Graal) that doesn't support the option `MaxVectorSize`, then `vm.opt.final.MaxVectorSize == "null"` holds. But this can't guarantee that the max vector size >= 16.
>
> I forgot to submit this comment. I thought I submitted it two days ago.

I thought someone may want to run the test in a configuration without C2. So, I didn't want to change the test for such cases. I leave such decisions to others. Maybe @dougxc has an opinion about Graal?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27805#discussion_r2438845933