RFR: 8369569: Rename methods in regmask.hpp to conform with HotSpot coding style

[Roberto Castañeda Lozano]

On Wed, 15 Oct 2025 08:14:26 GMT, Daniel Lundén <dlunden at openjdk.org> wrote:

> A number of methods in regmask.hpp do not conform with the HotSpot coding style. We should make sure they do.
> 
> ### Changeset
> - Rename methods in `regmask.hpp` to conform with HotSpot coding style.
> - Similarly rename directly related methods in `chaitin.hpp`.
> - Rename the constant register masks `All` and `Empty` to `ALL` and `EMPTY`.
> - Fix a few additional code style issues at lines touched by the changeset.
> 
> Note: this is a syntax-only changeset (no functional changes).
> 
> ### Testing
> 
> - [GitHub Actions](https://github.com/dlunde/jdk/actions/runs/18500704336)
> - `tier1` and HotSpot parts of `tier2` and `tier3` (and additional Oracle-internal testing) on Windows x64, Linux x64, Linux aarch64, macOS x64, and macOS aarch64.

Looks good otherwise!

test/hotspot/gtest/opto/test_regmask.cpp line 586:

> 584: }
> 585: 
> 586: TEST_VM(RegMask, Set_ALL_extended) {

Suggestion:

TEST_VM(RegMask, set_all_extended) {

test/hotspot/gtest/opto/test_regmask.cpp line 599:

> 597: }
> 598: 
> 599: TEST_VM(RegMask, Set_ALL_From_extended) {

Suggestion:

TEST_VM(RegMask, set_all_from_extended) {

test/hotspot/gtest/opto/test_regmask.cpp line 606:

> 604: }
> 605: 
> 606: TEST_VM(RegMask, Set_ALL_From_extended_grow) {

Suggestion:

TEST_VM(RegMask, set_all_from_extended_grow) {

test/hotspot/gtest/opto/test_regmask.cpp line 613:

> 611: }
> 612: 
> 613: TEST_VM(RegMask, Clear_extended) {

Suggestion:

TEST_VM(RegMask, clear_extended) {

test/hotspot/gtest/opto/test_regmask.cpp line 614:

> 612: 
> 613: TEST_VM(RegMask, Clear_extended) {
> 614:   // Check that Clear doesn't leave any stray bits on extended RegMasks.

Suggestion:

  // Check that clear doesn't leave any stray bits on extended RegMasks.

-------------

Marked as reviewed by rcastanedalo (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/27817#pullrequestreview-3349813577
PR Review Comment: https://git.openjdk.org/jdk/pull/27817#discussion_r2439574516
PR Review Comment: https://git.openjdk.org/jdk/pull/27817#discussion_r2439576190
PR Review Comment: https://git.openjdk.org/jdk/pull/27817#discussion_r2439578391
PR Review Comment: https://git.openjdk.org/jdk/pull/27817#discussion_r2439579707
PR Review Comment: https://git.openjdk.org/jdk/pull/27817#discussion_r2439581329