RFR: 8290892: C2: Intrinsify Reference.reachabilityFence [v11]
    Vladimir Ivanov 
    vlivanov at openjdk.org
       
    Fri Oct 17 20:01:53 UTC 2025
    
    
  
On Fri, 12 Sep 2025 14:06:15 GMT, Emanuel Peter <epeter at openjdk.org> wrote:
>> Vladimir Ivanov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Minor fix
>
> test/hotspot/jtreg/compiler/c2/TestReachabilityFence.java line 40:
> 
>> 38:  * @run main/othervm -Xbatch compiler.c2.TestReachabilityFence
>> 39:  */
>> 40: public class TestReachabilityFence {
> 
> This test seems very important to me. Can you please add some extra code comments, about what goes wrong before the fix, i.e. if RF are not present?
> 
> Maybe some explanation about what it took to write this test, so that we can build on that to extend the test later?
I added more comments in the test code to elaborate on the problematic scenario.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25315#discussion_r2441049200
    
    
More information about the hotspot-compiler-dev
mailing list