RFR: 8364766: C2: Improve Value() of DivI and DivL for non-constant inputs [v7]

Tobias Hotz duke at openjdk.org
Sun Oct 19 10:24:05 UTC 2025


On Sun, 19 Oct 2025 10:01:04 GMT, Tobias Hotz <duke at openjdk.org> wrote:

>> This PR improves the value of interger division nodes.
>> Currently, we only emit a good type if either input is constant. But we can also cover the generic case. It does that by finding the four corners of the division. This is guranteed to find the extrema that we can use for min/max. Some special logic is required for MIN_INT / -1, though, as this is a special case
>> We also need some special logic to handle ranges that cross zero, but in this case, we just need to check for the negative and positive range once.
>> This also cleans up and unifies the code paths for DivINode and DivLNode.
>> I've added some tests to validate the optimization. Without the changes, some of these tests fail.
>
> Tobias Hotz has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Adjust long constant folding test as well
>  - Adjust test, assert and comments

Thanks for all your reviews!
I've adjusted the tests and comments as per your suggestions. Please review again.
And sorry for the long delay @mhaessig !

-------------

PR Comment: https://git.openjdk.org/jdk/pull/26143#issuecomment-3419554041


More information about the hotspot-compiler-dev mailing list