RFR: 8353290: C2: Refactor PhaseIdealLoop::is_counted_loop() [v13]

[Kangcheng Xu]

On Fri, 10 Oct 2025 08:53:01 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Kangcheng Xu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8354383: C2: enable sinking of Type nodes out of loop
>>   
>>   Reviewed-by: chagedorn, thartmann
>>   (cherry picked from commit a2f99fd88bd03337e1ba73b413ffe4e39f3584cf)
>
> src/hotspot/share/opto/loopnode.cpp line 1814:
> 
>> 1812:   _iv_incr = PhaseIdealLoop::LoopIVIncr(incr, _head, _loop);
>> 1813:   _iv_incr.build();
>> 1814:   if (_iv_incr.incr() == nullptr) {
> 
> Why don't you also check with a `is_valid()` method here?

added `is_valid()` method to check regardless of iv basic type (which could be different from the loop itself).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24458#discussion_r2445182264