RFR: 8370225: RISC-V: move verify_frame_setup into ASSERT
    Fei Yang 
    fyang at openjdk.org
       
    Tue Oct 21 01:16:03 UTC 2025
    
    
  
On Mon, 20 Oct 2025 09:36:49 GMT, Hamlin Li <mli at openjdk.org> wrote:
> Hi,
> Can you help to review this patch?
> `verify_frame_setup` should be only declared/implemented/invoked in debug version.
> This is a leftover by https://bugs.openjdk.org/browse/JDK-8369947.
> 
> Thanks!
Does this make a difference? It has `NOT_DEBUG_RETURN` which will make it a NOP for release build.
376 #ifdef ASSERT
377 #define DEBUG_ONLY(code) code
378 #define NOT_DEBUG(code)
379 #define NOT_DEBUG_RETURN  /*next token must be ;*/
380 #else // ASSERT
381 #define DEBUG_ONLY(code)
382 #define NOT_DEBUG(code) code
383 #define NOT_DEBUG_RETURN {}
384 #endif // ASSERT
-------------
PR Review: https://git.openjdk.org/jdk/pull/27894#pullrequestreview-3358447440
    
    
More information about the hotspot-compiler-dev
mailing list