RFR: 8370225: RISC-V: cleanup verify_xxx in interp_masm_riscv.hpp [v2]

[Fei Yang]

On Tue, 21 Oct 2025 10:50:01 GMT, Hamlin Li <mli at openjdk.org> wrote:

>> src/hotspot/cpu/riscv/interp_masm_riscv.hpp line 306:
>> 
>>> 304:   void verify_access_flags(Register access_flags, uint32_t flag,
>>> 305:                            const char* msg, bool stop_by_hit = true) NOT_DEBUG_RETURN;
>>> 306:   void verify_frame_setup() NOT_DEBUG_RETURN;
>> 
>> OK. Then can you remove the surrounding ASSERT of the use sites for consistency? It becomes unnecessary after adding `NOT_DEBUG_RETURN`. One example:
>> 
>> 1075   // start execution
>> 1076 #ifdef ASSERT
>> 1077   __ verify_frame_setup();
>> 1078 #endif
>
> I think the `ASSERT`s around invocation of `verify_frame_setup` are already removed in this patch.

Ah, yes for this one. Sorry, I missed that. What about `verify_access_flags`?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27894#discussion_r2447680968