RFR: 8370378: Some compiler tests inadvertently exclude particular platforms

[Christian Hagedorn]

On Wed, 22 Oct 2025 07:52:13 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

> As @dholmes-ora described in JBS: For historical reasons `os.arch` is `amd64` on x86_64 Linux and Windows, but `x86_64` on macOS. I fixed the tests accordingly.
> 
> Thanks,
> Tobias

Looks good and trivial.

test/hotspot/jtreg/compiler/c2/TestBit.java line 36:

> 34:  *
> 35:  * @requires vm.flagless
> 36:  * @requires os.arch=="aarch64" | os.arch=="amd64" | os.arch=="x86_64" | os.arch == "ppc64" | os.arch == "ppc64le" | os.arch == "riscv64"

Suggestion:

 * @requires os.arch == "aarch64" | os.arch == "amd64" | os.arch=="x86_64" | os.arch == "ppc64" | os.arch == "ppc64le" | os.arch == "riscv64"

test/hotspot/jtreg/compiler/c2/irTests/RotateLeftNodeIntIdealizationTests.java line 34:

> 32:  * @library /test/lib /
> 33:  * @run driver compiler.c2.irTests.RotateLeftNodeIntIdealizationTests
> 34:  * @requires os.arch=="amd64" | os.arch=="x86_64" | os.arch == "aarch64" | (os.arch == "riscv64" & vm.cpu.features ~= ".*zbb.*")

For consistency:
Suggestion:

 * @requires os.arch == "amd64" | os.arch == "x86_64" | os.arch == "aarch64" | (os.arch == "riscv64" & vm.cpu.features ~= ".*zbb.*")

test/hotspot/jtreg/compiler/c2/irTests/RotateLeftNodeLongIdealizationTests.java line 34:

> 32:  * @library /test/lib /
> 33:  * @run driver compiler.c2.irTests.RotateLeftNodeLongIdealizationTests
> 34:  * @requires os.arch=="amd64" | os.arch=="x86_64" | os.arch == "aarch64" | (os.arch == "riscv64" & vm.cpu.features ~= ".*zbb.*")

Suggestion:

 * @requires os.arch == "amd64" | os.arch == "x86_64" | os.arch == "aarch64" | (os.arch == "riscv64" & vm.cpu.features ~= ".*zbb.*")

-------------

Marked as reviewed by chagedorn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/27931#pullrequestreview-3364238531
PR Review Comment: https://git.openjdk.org/jdk/pull/27931#discussion_r2450862970
PR Review Comment: https://git.openjdk.org/jdk/pull/27931#discussion_r2450861390
PR Review Comment: https://git.openjdk.org/jdk/pull/27931#discussion_r2450861938