RFR: 8367690: C2: Unneeded branch in reduce_phi

[duke]

On Thu, 16 Oct 2025 14:49:02 GMT, Anton Seoane Ampudia <aseoane at openjdk.org> wrote:

> This PR carries out a minor cleanup found in the Phi reduction code.
> 
> The combination of the branch and assert is redundant as the assert will always trigger. We can either remove the `else if` branch or change the assert for a `ShouldNotReachHere`.
> 
> I have gone for the former option here.
> 
> **Testing:** passes tiers 1-3

@anton-seoane 
Your change (at version c9624d03f79c7236226a4030bfc144c860dd60c4) is now ready to be sponsored by a Committer.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/27849#issuecomment-3431212119