RFR: 8361608: C2: assert(opaq->outcnt() == 1 && opaq->in(1) == limit) failed [v6]

[Marc Chevalier]

On Wed, 22 Oct 2025 15:22:26 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Marc Chevalier has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review
>
> src/hotspot/share/opto/loopnode.cpp line 4781:
> 
>> 4779:         }
>> 4780:         if (head->is_post_loop()) {
>> 4781:           assert(opaque->outcnt() == 1, "IGVN should have cleaned that up!");
> 
> I think it should not happen that they have more than one output, so the assert message is a bit misleading. Maybe change it to "opaque node should not be shared" or something like this. You could optionally also extend the assert message above. But otherwise, it looks good, thanks!

I've split the assert to give more meaningful messages.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27586#discussion_r2452501386