RFR: 8353290: C2: Refactor PhaseIdealLoop::is_counted_loop() [v17]

[Kangcheng Xu]

On Fri, 10 Oct 2025 08:49:58 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Kangcheng Xu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   mark LoopExitTest::is_valid_with_bt() const
>
> src/hotspot/share/opto/loopnode.cpp line 1884:
> 
>> 1882:   }
>> 1883: 
>> 1884:   // Trip-counter increment must be commutative & associative.
> 
> This comment did not really make sense. I checked its history and it started to be misplaced here:
> 
> https://github.com/openjdk/jdk/commit/baaa8f79ed93d4dc1444fed81599ab0f7c2dd395#diff-dc3fdd0572cfc2cb65bce10f08db4054dbaf1b3b94f8ad7883f6c120b4773cfeR332-R342
> 
> I suggest to move the comment again to the right place in your patch in `LoopIVIncr::build()`.

Done. Thank you for suggesting this.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24458#discussion_r2453082203