RFR: 8370481: C2 SuperWord: Long/Integer.compareUnsigned return wrong value in SLP [v5]

[Emanuel Peter]

On Thu, 23 Oct 2025 15:23:16 GMT, Hamlin Li <mli at openjdk.org> wrote:

>> Hi,
>> Can you help to review the patch? @eme64 
>> 
>> ##  Issue
>> 
>> Currently, in SLP when transform from (Bool + CmpU + CMove) to (VectorMaskCmp + VectorBlend), the unsigned-ness in CmpU is lost, then end up doing a signed instead of unsigned comparison in VectorMaskCmp.
>> For details please check code at `SuperWordVTransformBuilder::make_vector_vtnode_for_pack` and `PackSet::get_bool_test`.
>> 
>> ##  Fix
>> Currently, `BoolTest` does not support an unsigned construction (`BoolTest( mask btm ) : _test(btm) { assert((btm & unsigned_compare) == 0, "unsupported");}`), seems to me a feasible solution would be get the unsigned information from CmpU (which could be an input of Bool) and pass it to VectorMaskCmp.
>> 
>> Thanks
>> 
>> This pr could also lead to more optimizations, like: https://github.com/openjdk/jdk/pull/25336 and https://github.com/openjdk/jdk/pull/25341.
>
> Hamlin Li has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Update src/hotspot/share/opto/superword.cpp
>    
>    Co-authored-by: Emanuel Peter <emanuel.peter at oracle.com>
>  - Update src/hotspot/share/opto/superword.cpp
>    
>    Co-authored-by: Emanuel Peter <emanuel.peter at oracle.com>

test/hotspot/jtreg/compiler/c2/irTests/TestVectorConditionalMove.java line 1131:

> 1129:                  "testCMoveULGTforL",
> 1130:                  "testCMoveULGTforF",
> 1131:                  "testCMoveULGTforD",

I just realized that we only have `GT` cases. But what about `GE,LE,LT`? Are those covered somewhere else?

Otherwise we only test a fraction of
`static mask unsigned_mask(mask btm) { return mask(btm | unsigned_compare); }`

What do you think?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27942#discussion_r2455597841