RFR: 8369646: Detection of redundant conversion patterns in add_users_of_use_to_worklist is too restrictive [v3]
Benoît Maillard
bmaillard at openjdk.org
Mon Oct 27 08:42:39 UTC 2025
On Mon, 27 Oct 2025 08:08:41 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:
>> Benoît Maillard has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Missing -XX:+UnlockDiagnosticVMOptions
>
> test/hotspot/jtreg/compiler/c2/TestEliminateRedundantConversionSequences.java line 32:
>
>> 30: * @run main/othervm -XX:+IgnoreUnrecognizedVMOptions
>> 31: * -XX:CompileCommand=compileonly,compiler.c2.TestEliminateRedundantConversionSequences::test*
>> 32: * -XX:-TieredCompilation -Xbatch -XX:VerifyIterativeGVN=1110
>
> You could either add a separate run with `-XX:+StressIGVN` without a fixed seed or just add `-XX:+StressIGVN` here. I guess the latter is good enough.
I agree, and I just added `-XX:+StressIGVN` to the existing run.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27900#discussion_r2464815311
More information about the hotspot-compiler-dev
mailing list