RFR: 8347463: jdk/jfr/threading/TestManyVirtualThreads.java crashes with assert(oopDesc::is_oop_or_null(val)) [v2]

[Anton Seoane Ampudia]

On Mon, 27 Oct 2025 09:07:49 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

>> Anton Seoane Ampudia has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:
>> 
>>  - Merge branch 'openjdk:master' into JDK-8347463
>>  - Merge branch 'JDK-8347463' of github.com:anton-seoane/jdk into JDK-8347463
>>  - Merge branch 'openjdk:master' into JDK-8347463
>>  - Documentation for future similar cases
>>  - Test for JDK-8347463
>>  - Change to a more specific type
>>  - Runtime call had void type but actually returned an object
>
> test/hotspot/jtreg/compiler/intrinsics/TestReturnsOopSetForJFRWriteCheckpoint.java line 36:
> 
>> 34:  * @summary Tests that the getEventWriter call to write_checkpoint correctly
>> 35:  *          reports returning an oop
>> 36:  * @requires vm.hasJFR & vm.continuations
> 
> Do we need `vm.continuations`?

We don't. Removed the requirement

> test/hotspot/jtreg/compiler/intrinsics/TestReturnsOopSetForJFRWriteCheckpoint.java line 38:
> 
>> 36:  * @requires vm.hasJFR & vm.continuations
>> 37:  * @library /test/lib /
>> 38:  * @modules jdk.jfr/jdk.jfr.internal
> 
> Do we need this?

We don't. Removed as well!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27913#discussion_r2464983164
PR Review Comment: https://git.openjdk.org/jdk/pull/27913#discussion_r2464989996