RFR: 8370569: IGV: dump more graph properties at bytecode parsing [v2]

Roberto Castañeda Lozano rcastanedalo at openjdk.org
Mon Oct 27 10:28:30 UTC 2025


On Mon, 27 Oct 2025 08:11:28 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Roberto Castañeda Lozano has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Simplify code generated by NetBeans for the 'graphNameSuffixField' text field
>>  - Use '-' for non-existing maps
>
> src/utils/IdealGraphVisualizer/Settings/src/main/java/com/sun/hotspot/igv/settings/ViewPanel.java line 168:
> 
>> 166:     private void graphNameSuffixFieldActionPerformed(java.awt.event.ActionEvent evt) {//GEN-FIRST:event_graphNameSuffixFieldActionPerformed
>> 167:         // TODO add your handling code here:
>> 168:     }//GEN-LAST:event_graphNameSuffixFieldActionPerformed
> 
> Can you explain why this nop-action is needed?

Good catch. It is not needed, just the result of some spurious clicking on the NetBeans form editor that resulted in that code being auto-generated. I removed the action declaration and other GUI properties of the new text field to align the generated code with that of the other text fields in the Options form (commit 4123bb0c9ccb8b60993f4b575c36f9751cefd1b9).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27975#discussion_r2465139130


More information about the hotspot-compiler-dev mailing list