RFR: 8349835: C2: simplify IGV property printing [v2]
Saranya Natarajan
snatarajan at openjdk.org
Mon Oct 27 22:10:05 UTC 2025
On Wed, 22 Oct 2025 09:15:41 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:
>> Saranya Natarajan has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - fixing test failure
>> - addressing review comments
>
> src/hotspot/share/opto/idealGraphPrinter.hpp line 172:
>
>> 170: };
>> 171:
>> 172: class PrintProperties
>
> Do you really need it in the header file? You could also just move it the the source file directly where we use the class.
My reasoning is keep the interface and implementation separate. I have kept it this way. Will that be okay ?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26902#discussion_r2467196698
More information about the hotspot-compiler-dev
mailing list