Integrated: 8370220: C2: rename methods and improve documentation around get_ctrl and idom lazy updating/forwarding of ctrl and idom via dead ctrl nodes
Emanuel Peter
epeter at openjdk.org
Tue Oct 28 06:45:19 UTC 2025
On Mon, 20 Oct 2025 08:57:33 GMT, Emanuel Peter <epeter at openjdk.org> wrote:
> When working on https://github.com/openjdk/jdk/pull/27889, I was irritated by the lack of documentation and suboptimal naming.
>
> Here, I'm doing the following:
> - Add more documentation, and improve it in other cases.
> - Rename "lazy" methods: "lazy" could indicate that we delay it somehow until later, but it is unclear what is delayed.
> - `lazy_replace` -> `replace_ctrl_node_and_forward_ctrl_and_idom`
> - `lazy_update` -> `install_lazy_ctrl_and_idom_forwarding`
> - Made some methods private, and added some additional asserts.
>
> I'd be more than happy for even better names, and suggestions how to improve the documentation further :)
>
> Related issues:
> https://github.com/openjdk/jdk/pull/27889
> https://github.com/openjdk/jdk/pull/15720
This pull request has now been integrated.
Changeset: d5ce6669
Author: Emanuel Peter <epeter at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/d5ce66698d2f15c5f8316110a6118a10baa4013d
Stats: 126 lines in 8 files changed: 63 ins; 4 del; 59 mod
8370220: C2: rename methods and improve documentation around get_ctrl and idom lazy updating/forwarding of ctrl and idom via dead ctrl nodes
Reviewed-by: chagedorn, thartmann
-------------
PR: https://git.openjdk.org/jdk/pull/27892
More information about the hotspot-compiler-dev
mailing list