RFR: 8370708: RISC-V: Add VerifyStackAtCalls [v2]

[Robbin Ehn]

On Tue, 28 Oct 2025 02:50:18 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Robbin Ehn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   li->mv, format, space
>
> src/hotspot/cpu/riscv/riscv.ad line 1413:
> 
>> 1411:   __ build_frame(framesize);
>> 1412: 
>> 1413:   if (VerifyStackAtCalls) {
> 
> I think this should be reflected in `MachPrologNode::format` at the same time.

Fixed

> src/hotspot/cpu/riscv/riscv.ad line 1414:
> 
>> 1412: 
>> 1413:   if (VerifyStackAtCalls) {
>> 1414:     __ li(t2, MAJIK_DWORD);
> 
> Can you use `mv` instead here for consistency with other places where we move an immediate? If `li` is prefered, we might want to do a separate change handling all the places. But I don't have a strong bias.

Fixed

> src/hotspot/cpu/riscv/riscv.ad line 2440:
> 
>> 2438:       Label CHECK_PASSED;
>> 2439:       __ ld(t1, Address(sp, framesize));
>> 2440:       __ li(t2, MAJIK_DWORD);
> 
> Similar here.

Fixed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28005#discussion_r2468195870
PR Review Comment: https://git.openjdk.org/jdk/pull/28005#discussion_r2468196406
PR Review Comment: https://git.openjdk.org/jdk/pull/28005#discussion_r2468196934