RFR: 8361608: C2: assert(opaq->outcnt() == 1 && opaq->in(1) == limit) failed [v9]

[Marc Chevalier]

On Mon, 27 Oct 2025 07:45:39 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Marc Chevalier has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Rename test
>
> test/hotspot/jtreg/compiler/loopopts/TooStrictAssertForUnrollAfterPeeling.java line 54:
> 
>> 52:  *                   -XX:-SplitIfBlocks
>> 53:  *                   -XX:-UseOnStackReplacement
>> 54:  *                   -XX:LoopMaxUnroll=2
> 
> Are these flags all required to trigger the issue or what is the motivation behind having this run compared to the above only?

That's the one in the reproducer you've crafted that give a simpler graph, if I remember correctly. I think it's valuable because the graph shape is different so it might trigger some asserts differently, exercise other paths, and if it breaks again, maybe someone who will have to look at it will be happy to find a run with a simpler graph. Maybe I can add in the summary that "if it helps investigate an issue, the @run 3 and 5 (with more flags) are expected to give a simpler graph".

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27586#discussion_r2468209976