RFR: 8370708: RISC-V: Add VerifyStackAtCalls [v2]

Fei Yang fyang at openjdk.org
Tue Oct 28 07:35:03 UTC 2025


On Tue, 28 Oct 2025 07:24:40 GMT, Robbin Ehn <rehn at openjdk.org> wrote:

>> Hi, please consider.
>> 
>> Sanity tested, running t1.
>> 
>> Thanks, Robbin
>
> Robbin Ehn has updated the pull request incrementally with one additional commit since the last revision:
> 
>   li->mv, format, space

Thanks for the quick update.

src/hotspot/cpu/riscv/riscv.ad line 2443:

> 2441:       // Check that stack depth is unchanged: find majik cookie on stack
> 2442:       int framesize = ra_->reg2offset_unchecked(OptoReg::add(ra_->_matcher._old_SP, -3 * VMRegImpl::slots_per_word));
> 2443:       Label CHECK_PASSED;

Nit: We rarely use big names for labels. Maybe `Label stack_ok`?

-------------

Marked as reviewed by fyang (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/28005#pullrequestreview-3387053687
PR Review Comment: https://git.openjdk.org/jdk/pull/28005#discussion_r2468230474


More information about the hotspot-compiler-dev mailing list