RFR: 8370708: RISC-V: Add VerifyStackAtCalls [v2]
    Robbin Ehn 
    rehn at openjdk.org
       
    Tue Oct 28 07:48:53 UTC 2025
    
    
  
On Tue, 28 Oct 2025 07:37:22 GMT, Robbin Ehn <rehn at openjdk.org> wrote:
>> src/hotspot/cpu/riscv/riscv.ad line 2443:
>> 
>>> 2441:       // Check that stack depth is unchanged: find majik cookie on stack
>>> 2442:       int framesize = ra_->reg2offset_unchecked(OptoReg::add(ra_->_matcher._old_SP, -3 * VMRegImpl::slots_per_word));
>>> 2443:       Label CHECK_PASSED;
>> 
>> Nit: We rarely use big names for labels. Maybe `Label stack_ok`?
>
> Yea, sure.
> 
> Personally I prefer labels to stand out as control transfer is a bit tricky to keep track of in assembly.
Fixed
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28005#discussion_r2468267302
    
    
More information about the hotspot-compiler-dev
mailing list