RFR: 8367292: VectorAPI: Optimize VectorMask.fromLong/toLong() for SVE [v3]

Emanuel Peter epeter at openjdk.org
Tue Oct 28 10:30:04 UTC 2025


On Tue, 28 Oct 2025 10:24:59 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Current comment might be confusing. I will use `requires` both in comments and method name. Hope this would be more clear. WDYT?
>
> Well, we went with `prefers` because you said that on `aarch64` both are implemented, see our conversation above. So we are now spinning in circles.
> 
> I would approach it like this:
> Write down what it means if the method returns true, and what it means if it returns false. Make sure to use `requires`, if anything else is not permitted/implemented. Use `prefers` if both are permitted/implemented, but one is preferred.

Another idea: use a return `Enum`. Then you can give things names, which can sometimes be more helpful than `true/false`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27481#discussion_r2468933077


More information about the hotspot-compiler-dev mailing list