RFR: 8327963: C2: fix construction of memory graph around Initialize node to prevent incorrect execution if allocation is removed [v15]
    Roland Westrelin 
    roland at openjdk.org
       
    Tue Oct 28 13:35:19 UTC 2025
    
    
  
On Fri, 24 Oct 2025 13:21:04 GMT, Emanuel Peter <epeter at openjdk.org> wrote:
>> Roland Westrelin has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - review
>>  - Roberto's patches
>
> src/hotspot/share/opto/multnode.hpp line 232:
> 
>> 230: };
>> 231: 
>> 232: template <class Callback> ProjNode* MultiNode::apply_to_projs(DUIterator_Fast& imax, DUIterator_Fast& i, Callback callback, uint which_proj) const {
> 
> Does this not belong right after the `MultiNode`? Or even in `multnode.cpp`?
It needs the `ProjNode` declaration because it accesses `proj->_con` and can't be in `multnode.cpp` because of the template parameter.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24570#discussion_r2469591960
    
    
More information about the hotspot-compiler-dev
mailing list