RFR: 8370708: RISC-V: Add VerifyStackAtCalls [v4]
Fei Yang
fyang at openjdk.org
Tue Oct 28 15:19:25 UTC 2025
On Tue, 28 Oct 2025 12:44:37 GMT, Robbin Ehn <rehn at openjdk.org> wrote:
>> Hi, please consider.
>>
>> Sanity tested and no issues with MAJIK t1 (with +VSC).
>>
>> Thanks, Robbin
>
> Robbin Ehn has updated the pull request incrementally with one additional commit since the last revision:
>
> Fixed format
src/hotspot/cpu/riscv/riscv.ad line 1375:
> 1373: if (VerifyStackAtCalls) {
> 1374: st->print("mv t2, %ld\n\t", MAJIK_DWORD);
> 1375: st->print("sd t2, [sp, #%d]\n\t", - 3 * wordSize);
Thanks for the update. You might want to change this into `st->print("sd t2, [sp, #%d]\n\t", framesize - 3 * wordSize);` at the same time. BTW: My local `hs:tier1` with `-XX:+VerifyStackAtCalls` using fastdebug build is good.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28005#discussion_r2469973749
More information about the hotspot-compiler-dev
mailing list