RFR: 8369456: [TESTBUG] Fix the test failure of TestSelectFromTwoVectorOp.java on sve2 platforms [v2]
    erifan 
    duke at openjdk.org
       
    Thu Oct 30 08:53:40 UTC 2025
    
    
  
On Wed, 29 Oct 2025 10:06:02 GMT, Emanuel Peter <epeter at openjdk.org> wrote:
>> test/hotspot/jtreg/compiler/vectorapi/TestSelectFromTwoVectorOp.java line 221:
>> 
>>> 219:     @IR(counts = {IRNode.SELECT_FROM_TWO_VECTOR_VB, IRNode.VECTOR_SIZE_64, ">0"},
>>> 220:         applyIfCPUFeature = {"sve2", "true"},
>>> 221:         applyIf = {"MaxVectorSize", "64"})
>> 
>> Would it make sense to add some IR rule for cases with `MaxVectorSize > 64`? Because now you just weakened the test, rather than ensuring that there is a test for larger sizes.
>
> Maybe it would be enough to just remove the `, IRNode.VECTOR_SIZE_64`, so that the test could check for the largest vector length available on the platform?
Hi @eme64 thanks for your review. As the vector species is fixed `ByteVector.SPECIES_512`, removing `IRNode.VECTOR_SIZE_64` doesn't work. Adding a rule for cases where `MaxVectorSize > 64` makes sense to me. I'll add the rule in the next commit, thanks~
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27723#discussion_r2476919178
    
    
More information about the hotspot-compiler-dev
mailing list