RFR: 8370409: Incorrect computation in Float16 reduction loop [v2]
Jatin Bhateja
jbhateja at openjdk.org
Thu Oct 30 09:01:40 UTC 2025
On Thu, 30 Oct 2025 07:06:41 GMT, Emanuel Peter <epeter at openjdk.org> wrote:
>> Jatin Bhateja has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Review comments resolutions
>
> test/hotspot/jtreg/compiler/c2/TestFloat16Reduction.java line 161:
>
>> 159: GOLDEN_MAX = MAXReduceLong();
>> 160: GOLDEN_MIN = MINReduceLong();
>> 161: }
>
> A total nit, and optional: you could make the fields static, and just assign values as you declare the fields. That would save you doing it all in the constructor.
Done
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27977#discussion_r2476947040
More information about the hotspot-compiler-dev
mailing list