Integrated: 8366357: C2 SuperWord: refactor VTransformNode::apply with VTransformApplyState

Emanuel Peter epeter at openjdk.org
Mon Sep 1 06:59:53 UTC 2025


On Thu, 28 Aug 2025 12:57:44 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

> I'm working on **cost-modeling**, and am integrating some smaller changes from this proof-of-concept PR: https://github.com/openjdk/jdk/pull/20964
> [See plan overfiew.](https://bugs.openjdk.org/browse/JDK-8340093)
> 
> This is a **pure refactoring** - no change in behaviour. I'm presenting it like this because it will make reviews easier.
> 
> The goal here is that `VTransformNode::apply` only needs a single argument. This is important, as we will soon add more components that need to be updated during apply. That way, we can simply add more parts to `VTransformApplyState`, and do not need to add more arguments to VTransformNode::apply.
> 
> And yes: I have considering passing the `apply_state` as `const`. While this may be possible with the current code state, the upcoming changes from https://github.com/openjdk/jdk/pull/20964 will require non-const access to the `apply_state` (e.g. for `set_memory_state`).
> 
> Also: Christian asked me to squeeze in some other change: `igvn.intcon` -> `phase->intcon`, so that we also set the control to root. It's not been strictly necessary, but probably better to do it.

This pull request has now been integrated.

Changeset: dbac620b
Author:    Emanuel Peter <epeter at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/dbac620b996713087f0d1b1189e543e51a0bb09f
Stats:     131 lines in 3 files changed: 31 ins; 26 del; 74 mod

8366357: C2 SuperWord: refactor VTransformNode::apply with VTransformApplyState

Reviewed-by: chagedorn, kvn, mhaessig

-------------

PR: https://git.openjdk.org/jdk/pull/26987


More information about the hotspot-compiler-dev mailing list