RFR: 8365926: RISC-V: Performance regression in renaissance (chi-square) [v2]

Robbin Ehn rehn at openjdk.org
Mon Sep 1 08:56:25 UTC 2025


On Mon, 1 Sep 2025 07:04:20 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Robbin Ehn has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>> 
>>  - Merge branch 'master' into 8365926
>>  - Spelling
>>  - Merge branch 'master' into 8365926
>>  - draft jal<->jalr
>
> src/hotspot/cpu/riscv/nativeInst_riscv.cpp line 125:
> 
>> 123:   set_stub_address_destination_at(stub_addr, dest);
>> 124: 
>> 125:   // patches jalr -> jal/jal -> jalr depeding on dest
> 
> Suggestion: s/depeding/depending/

Fixed

> src/hotspot/cpu/riscv/nativeInst_riscv.cpp line 146:
> 
>> 144: 
>> 145:     address dest = stub_address_destination_at(stub_addr);
>> 146:     optimize_call(dest, false); // patches jalr -> jal/jal -> jalr depeding on dest
> 
> Suggestion: s/depeding/depending/

Fixed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26944#discussion_r2313319741
PR Review Comment: https://git.openjdk.org/jdk/pull/26944#discussion_r2313319894


More information about the hotspot-compiler-dev mailing list