RFR: 8325467: Support methods with many arguments in C2 [v24]

Emanuel Peter epeter at openjdk.org
Tue Sep 2 14:08:05 UTC 2025


On Mon, 1 Sep 2025 16:01:23 GMT, Daniel Lundén <dlunden at openjdk.org> wrote:

>> Oh gosh, I just realized: machine word of course depends on 32bit vs 64bit architecture. Yikes.
>> So maybe the names need to be stack-slots vs words? And there should probably be a quick reminder somewhere that words can be different sizes.
>
> Sure, we can rename them. I think `RM_SIZE_IN_INTS` and `RM_SIZE_IN_WORDS` would be most suitable. I avoided such a change in this changeset to not make it bigger than it already is. Isn't it easier to do the renaming in a follow-up RFE though, instead of before this PR? I'm fine with both though, not that much extra work to do it before.

I think it would be easier to review if you do it first.
That PR won't be super controversial, and just makes the code nicer.
And then when we come back here, we may even be able to drop some comments, or be able to catch bugs just because the reviewers understand better what's going on ;)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20404#discussion_r2316205052


More information about the hotspot-compiler-dev mailing list