RFR: 8366747: RISC-V: Improve VerifyMethodHandles for method handle linkers [v2]

Anjian Wen wenanjian at openjdk.org
Wed Sep 3 02:40:28 UTC 2025


On Wed, 3 Sep 2025 01:40:43 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Anjian Wen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add assertion and modify format
>
> src/hotspot/cpu/riscv/methodHandles_riscv.cpp line 100:
> 
>> 98:   __ verify_method_ptr(method);
>> 99:   if (VerifyMethodHandles) {
>> 100:     Label L_ok;
> 
> Can you add an assertion here about the registers? Like: `assert_different_registers(method, t0, t1);`

Thanks for the review, I have added the assertion.

> src/hotspot/cpu/riscv/methodHandles_riscv.cpp line 102:
> 
>> 100:     Label L_ok;
>> 101:     const Register method_holder = t1;
>> 102:     __ load_method_holder(method_holder, method);
> 
> Please leave a new line before the swith-case structure.

done

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26938#discussion_r2317610255
PR Review Comment: https://git.openjdk.org/jdk/pull/26938#discussion_r2317610296


More information about the hotspot-compiler-dev mailing list