RFR: 8350864: C2: verify structural invariants of the Ideal graph [v3]

[Marc Chevalier]

On Mon, 25 Aug 2025 14:16:42 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> src/hotspot/share/opto/graphInvariants.cpp line 287:
>> 
>>> 285:       }
>>> 286:     }
>>> 287:     return r;
>> 
>> Also this could probably be handled with a pattern wrapping mechanism, right?
>> `FailOnlyForLiveNodes( <the pattern from above> )`
>
> I'm just suggesting it in case you need to do this sort of special-casing elsewhere too ;)

That would be possible. It's still rare, and I'm not convinced we should make so specialized such patterns for one usecase. If it gets more usage, sure, that would be something to do. The only other usage is not so easy to phrase as template.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26362#discussion_r2321687572