RFR: 8351623: VectorAPI: Add SVE implementation of subword gather load operation [v5]

Xiaohong Gong xgong at openjdk.org
Mon Sep 8 03:03:14 UTC 2025


On Fri, 5 Sep 2025 10:41:15 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> src/hotspot/share/opto/vectornode.hpp line 1774:
>> 
>>> 1772:     : VectorNode(vec1, vec2, vt) {
>>> 1773:     assert(type2aelembytes(vec1->bottom_type()->is_vect()->element_basic_type()) ==
>>> 1774:            type2aelembytes(vt->element_basic_type()) * 2, "must be half size");
>> 
>> What about asserting that `vec1` and `vec2` have the same `vect`?
>
> And what about the vector length being consistent between `vec1`, `vec2` and `vt`?

> What about asserting that `vec1` and `vec2` have the same `vect`?

That would be fine. Thanks! I will add it in next commit.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26236#discussion_r2329026579


More information about the hotspot-compiler-dev mailing list