RFR: 8366971: C2: Remove unused nop_list from PhaseOutput::init_buffer

Tue Sep 9 08:08:36 UTC 2025

On Fri, 5 Sep 2025 13:02:00 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:

> The nop list has never been used in the history of OpenJDK. Let's clean it up.
> 
> Tested with Mach5 tier 1-5, no related failures.

Looks quite reasonable. Thanks for cleaning the code :)

src/hotspot/cpu/ppc/ppc.ad line 4926:

> 4924:   // Unused, list one so that array generated by adlc is not empty.
> 4925:   // Aix compiler chokes if _nop_count = 0.
> 4926:   nops(fxNop);

There seems to be some justification here why we needed to have the list.
Can you quickly say why we should not be worried about that now? ;)

-------------

PR Review: https://git.openjdk.org/jdk/pull/27117#pullrequestreview-3199928796
PR Review Comment: https://git.openjdk.org/jdk/pull/27117#discussion_r2332395694