RFR: 8350864: C2: verify structural invariants of the Ideal graph [v5]

[Emanuel Peter]

On Tue, 9 Sep 2025 13:38:00 GMT, Marc Chevalier <mchevalier at openjdk.org> wrote:

>> src/hotspot/share/opto/graphInvariants.cpp line 116:
>> 
>>> 114: private:
>>> 115:   const N*& _binding;
>>> 116: };
>> 
>> Would it not make sense to move it a bit closer to the related code? Do you need it much before `NodeClassIsAndBind`?
>
> `TypedBind` is like `Bind` they are both matching the same nodes as `TruePattern` just before. I think the grouping makes more sense than splitting `Bind` (whose comment refers ti `TruePattern`) and `TypedBind`. It makes more sense to hoist `NodeClass` here, even if their relation is rather light: used in the same macro.

Up to you :)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26362#discussion_r2333768687