RFR: 8350864: C2: verify structural invariants of the Ideal graph [v5]

[Emanuel Peter]

On Tue, 9 Sep 2025 14:08:04 GMT, Marc Chevalier <mchevalier at openjdk.org> wrote:

>> src/hotspot/share/opto/graphInvariants.cpp line 211:
>> 
>>> 209:   AtInput(uint which_input, const Pattern* pattern) : _which_input(which_input), _pattern(pattern) {}
>>> 210:   bool check(const Node* center, Node_List& steps, GrowableArray<int>& path, stringStream& ss) const override {
>>> 211:     assert(_which_input < center->req(), "Input number is out of range");
>> 
>> Hmm. Could still be nice if we did our best here, and responded nicely.
>> Just in case someone messes up the pattern, and then we get an assert here.
>> Maybe the bug is hard to reproduce, and having the printed statements would have helped a little?
>
>> having the printed statements
> 
> which statements?

I meant your error messages that you put to the `ss` :)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26362#discussion_r2333793502