RFR: 8360031: C2 compilation asserts in MemBarNode::remove [v4]

[Damon Fenacci]

On Mon, 8 Sep 2025 23:53:49 GMT, Dean Long <dlong at openjdk.org> wrote:

>> Damon Fenacci has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   JDK-8360031: add assert condition and make consume method argument escape
>
> src/hotspot/share/opto/memnode.cpp line 4232:
> 
>> 4230: 
>> 4231: void MemBarNode::remove(PhaseIterGVN *igvn) {
>> 4232:   if (outcnt() != 2) {
> 
> By itself, this allows outcnt() == 0, so maybe we need to continue to fail if that happens.

I added the condition to the assert.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26556#discussion_r2334037886