RFR: 8356813: Improve Mod(I|L)Node::Value [v7]
Hannes Greule
hgreule at openjdk.org
Wed Sep 10 19:32:58 UTC 2025
On Wed, 10 Sep 2025 10:25:00 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:
>> Hannes Greule has updated the pull request incrementally with one additional commit since the last revision:
>>
>> review
>
> src/hotspot/share/opto/divnode.cpp line 1225:
>
>> 1223: const TypeInteger* i1 = t1->isa_integer(bt);
>> 1224: const TypeInteger* i2 = t2->isa_integer(bt);
>> 1225: if (i1 == nullptr || i2 == nullptr) {
>
> If they are not `TOP` here, `isa_integer` should never return `nullptr`, it's better to do an `assert` here.
I guess using `is_integer` directly might make sense then?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25254#discussion_r2337712152
More information about the hotspot-compiler-dev
mailing list