RFR: 8367406: Simple refactoring AOTCodeAddressTable::id_for_address

Hamlin Li mli at openjdk.org
Thu Sep 11 10:49:22 UTC 2025


Hi,
Can you help to review this simple refactoring?

AOTCodeAddressTable::id_for_address currently is implemented in a way that introduce too many nested if/else, seems we could make the code more readable by removing these nested if/else. But it's quite subjective, so I'll let you tell if the patch is helpful.

Run tests (test/hotspot/jtreg/runtime/cds/appcds/aot*), no new failures on x64.

Thanks!

-------------

Commit messages:
 - initial commit

Changes: https://git.openjdk.org/jdk/pull/27217/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=27217&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8367406
  Stats: 60 lines in 1 file changed: 9 ins; 12 del; 39 mod
  Patch: https://git.openjdk.org/jdk/pull/27217.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/27217/head:pull/27217

PR: https://git.openjdk.org/jdk/pull/27217


More information about the hotspot-compiler-dev mailing list