RFR: 8364305: Support AVX10 saturating floating point conversion instructions [v11]
Sandhya Viswanathan
sviswanathan at openjdk.org
Thu Sep 11 17:02:40 UTC 2025
On Thu, 11 Sep 2025 02:19:54 GMT, Mohamed Issa <missa at openjdk.org> wrote:
>> Intel® AVX10 ISA [1] extensions added new saturating floating point conversion instructions which comply with definitions in section 5.8 of the 2019 IEEE-754 standard. They can compute floating point to integral type conversions while also handling special inputs such as NaN, +Infinity, and -Infinity.
>>
>> Without AVX10.2, the current approach starts by converting the floating point value(s) in the source register to the desired integral value(s) in the destination register. In the scalar case, the CVTTSS2SI (single precision) or CVTTSD2SI (double precision) instruction is used. In the vector case, the CVTTPS2DQ (single precision) or CVTTPD2DQ (double precision) is used. However, if the source contains a special value (NaN, -Infinity, +Infinity, <= Integer.MIN_VALUE, or >= Integer.MAX_VALUE), extra handling is required. The specific sequence of instructions involved depends on the source (single precision vs double precision), destination (long, integer, short, or byte), level of parallelization (scalar vs vector), and supported AVX extension type. Essentially though, the special values are mapped to values (NaN -> 0, -Infinity, <= Integer.MIN_VALUE -> Integer.MIN_VALUE, +Infinity, >= Integer.MAX_VALUE -> Integer.MAX_VALUE) in the integer range with the help of a few temporary regis
ters to store intermediate results.
>>
>> This change uses the new AVX10.2 scalar (VCVTTSS2SIS or VCVTTSD2SIS) and vector (VCVTTPS2QQS, VCVTTPS2DQS, VCVTTPD2QQS, and VCVTTPD2DQS) instructions on supported platforms to avoid the extra handling described above. Also, the JTREG tests listed below were used to verify correctness with `-XX:-UseSuperWord` / `-XX:+UseSuperWord` options to exercise both scalar and vector paths. The baseline build used is [OpenJDK v26-b11](https://github.com/openjdk/jdk/releases/tag/jdk-26%2B11).
>>
>> 1. `jtreg:test/hotspot/jtreg/compiler/codegen/TestByteDoubleVect.java`
>> 2. `jtreg:test/hotspot/jtreg/compiler/codegen/TestByteFloatVect.java`
>> 3. `jtreg:test/hotspot/jtreg/compiler/codegen/TestIntDoubleVect.java`
>> 4. `jtreg:test/hotspot/jtreg/compiler/codegen/TestIntFloatVect.java`
>> 5. `jtreg:test/hotspot/jtreg/compiler/codegen/TestLongDoubleVect.java`
>> 6. `jtreg:test/hotspot/jtreg/compiler/codegen/TestLongFloatVect.java`
>> 7. `jtreg:test/hotspot/jtreg/compiler/codegen/TestShortDoubleVect.java`
>> 8. `jtreg:test/hotspot/jtreg/compiler/codegen/TestShortFloatVect.java`
>> 9. `jtreg:test/hotspot/jtreg/compiler/vectorapi/VectorFPtoIntCastTest.java`
>> 1...
>
> Mohamed Issa has updated the pull request incrementally with two additional commits since the last revision:
>
> - Check for instructions that shouldn't appear in vector floating point conversion tests
> - Correctly calculate vector lengths and don't rely on VectorReinterpret in cast2F2X and cast2D2X memory instructions
test/hotspot/jtreg/compiler/lib/ir_framework/IRNode.java line 496:
> 494: public static final String CAST_F2X = PREFIX + "CAST_F2X" + POSTFIX;
> 495: static {
> 496: machOnlyNameRegex(CAST_F2X, "castF2X_reg_(av|eve)x");
This should be "castFtoX_reg_(av|eve)x".
test/hotspot/jtreg/compiler/lib/ir_framework/IRNode.java line 501:
> 499: public static final String CAST_D2X = PREFIX + "CAST_D2X" + POSTFIX;
> 500: static {
> 501: machOnlyNameRegex(CAST_D2X, "castD2X_reg_(av|eve)x");
This should be "castDtoX_reg_(av|eve)x".
test/hotspot/jtreg/compiler/lib/ir_framework/IRNode.java line 506:
> 504: public static final String CAST2_F2X = PREFIX + "CAST2_F2X" + POSTFIX;
> 505: static {
> 506: machOnlyNameRegex(CAST2_F2X, "cast2F2X_(reg|mem)_evex");
This should be "cast2FtoX_(reg|mem)_evex"
test/hotspot/jtreg/compiler/lib/ir_framework/IRNode.java line 511:
> 509: public static final String CAST2_D2X = PREFIX + "CAST2_D2X" + POSTFIX;
> 510: static {
> 511: machOnlyNameRegex(CAST2_D2X, "cast2D2X_(reg|mem)_evex");
This should be "cast2DtoX_(reg|mem)_evex".
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26919#discussion_r2341775174
PR Review Comment: https://git.openjdk.org/jdk/pull/26919#discussion_r2341782092
PR Review Comment: https://git.openjdk.org/jdk/pull/26919#discussion_r2341784055
PR Review Comment: https://git.openjdk.org/jdk/pull/26919#discussion_r2341787294
More information about the hotspot-compiler-dev
mailing list