RFR: 8364305: Support AVX10 saturating floating point conversion instructions [v11]
Jatin Bhateja
jbhateja at openjdk.org
Thu Sep 11 17:31:14 UTC 2025
On Thu, 11 Sep 2025 02:19:54 GMT, Mohamed Issa <missa at openjdk.org> wrote:
>> Intel® AVX10 ISA [1] extensions added new saturating floating point conversion instructions which comply with definitions in section 5.8 of the 2019 IEEE-754 standard. They can compute floating point to integral type conversions while also handling special inputs such as NaN, +Infinity, and -Infinity.
>>
>> Without AVX10.2, the current approach starts by converting the floating point value(s) in the source register to the desired integral value(s) in the destination register. In the scalar case, the CVTTSS2SI (single precision) or CVTTSD2SI (double precision) instruction is used. In the vector case, the CVTTPS2DQ (single precision) or CVTTPD2DQ (double precision) is used. However, if the source contains a special value (NaN, -Infinity, +Infinity, <= Integer.MIN_VALUE, or >= Integer.MAX_VALUE), extra handling is required. The specific sequence of instructions involved depends on the source (single precision vs double precision), destination (long, integer, short, or byte), level of parallelization (scalar vs vector), and supported AVX extension type. Essentially though, the special values are mapped to values (NaN -> 0, -Infinity, <= Integer.MIN_VALUE -> Integer.MIN_VALUE, +Infinity, >= Integer.MAX_VALUE -> Integer.MAX_VALUE) in the integer range with the help of a few temporary regis
ters to store intermediate results.
>>
>> This change uses the new AVX10.2 scalar (VCVTTSS2SIS or VCVTTSD2SIS) and vector (VCVTTPS2QQS, VCVTTPS2DQS, VCVTTPD2QQS, and VCVTTPD2DQS) instructions on supported platforms to avoid the extra handling described above. Also, the JTREG tests listed below were used to verify correctness with `-XX:-UseSuperWord` / `-XX:+UseSuperWord` options to exercise both scalar and vector paths. The baseline build used is [OpenJDK v26-b11](https://github.com/openjdk/jdk/releases/tag/jdk-26%2B11).
>>
>> 1. `jtreg:test/hotspot/jtreg/compiler/codegen/TestByteDoubleVect.java`
>> 2. `jtreg:test/hotspot/jtreg/compiler/codegen/TestByteFloatVect.java`
>> 3. `jtreg:test/hotspot/jtreg/compiler/codegen/TestIntDoubleVect.java`
>> 4. `jtreg:test/hotspot/jtreg/compiler/codegen/TestIntFloatVect.java`
>> 5. `jtreg:test/hotspot/jtreg/compiler/codegen/TestLongDoubleVect.java`
>> 6. `jtreg:test/hotspot/jtreg/compiler/codegen/TestLongFloatVect.java`
>> 7. `jtreg:test/hotspot/jtreg/compiler/codegen/TestShortDoubleVect.java`
>> 8. `jtreg:test/hotspot/jtreg/compiler/codegen/TestShortFloatVect.java`
>> 9. `jtreg:test/hotspot/jtreg/compiler/vectorapi/VectorFPtoIntCastTest.java`
>> 1...
>
> Mohamed Issa has updated the pull request incrementally with two additional commits since the last revision:
>
> - Check for instructions that shouldn't appear in vector floating point conversion tests
> - Correctly calculate vector lengths and don't rely on VectorReinterpret in cast2F2X and cast2D2X memory instructions
src/hotspot/cpu/x86/x86.ad line 7719:
> 7717: is_integral_type(Matcher::vector_element_basic_type(n)));
> 7718: match(Set dst (VectorCastF2X src));
> 7719: format %{ "vector_cast2r_f2x $dst, $src\t!" %}
Suggestion:
format %{ "vector_cast_f2x_saturating $dst, $src\t!" %}
src/hotspot/cpu/x86/x86.ad line 7732:
> 7730: is_integral_type(Matcher::vector_element_basic_type(n)));
> 7731: match(Set dst (VectorCastF2X (LoadVector src)));
> 7732: format %{ "vector_cast2m_f2x $dst, $src\t!" %}
Suggestion:
format %{ "vector_cast_f2x_saturating $dst, $src\t!" %}
src will be represented by appropriate addressing scheme for the memory operand
src/hotspot/cpu/x86/x86.ad line 7793:
> 7791: is_integral_type(Matcher::vector_element_basic_type(n)));
> 7792: match(Set dst (VectorCastD2X src));
> 7793: format %{ "vector_cast2r_d2x $dst, $src\t!" %}
Suggestion:
format %{ "vector_cast_d2x_saturating $dst, $src\t!" %}
src/hotspot/cpu/x86/x86.ad line 7806:
> 7804: is_integral_type(Matcher::vector_element_basic_type(n)));
> 7805: match(Set dst (VectorCastD2X (LoadVector src)));
> 7806: format %{ "vector_cast2m_d2x $dst, $src\t!" %}
Suggestion:
format %{ "vector_cast_d2x_saturating $dst, $src\t!" %}
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26919#discussion_r2341851882
PR Review Comment: https://git.openjdk.org/jdk/pull/26919#discussion_r2341859872
PR Review Comment: https://git.openjdk.org/jdk/pull/26919#discussion_r2341861234
PR Review Comment: https://git.openjdk.org/jdk/pull/26919#discussion_r2341861814
More information about the hotspot-compiler-dev
mailing list