RFR: 8367397: Improve naming and terminology in regmask.hpp and regmask.cpp [v2]

[Daniel Lundén]

On Thu, 11 Sep 2025 23:47:39 GMT, Dean Long <dlong at openjdk.org> wrote:

>> Daniel Lundén has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Lowercase _RM_INT and _RM_WORD
>
> src/hotspot/share/opto/chaitin.cpp line 1580:
> 
>> 1578:     _ifg->re_insert(lidx);
>> 1579:     if( !lrg->alive() ) continue;
>> 1580:     // capture allstackedness flag before mask is hacked
> 
> allstackedness --> infiniteness?

Thanks, I did not think to `grep` for that one...

> src/hotspot/share/opto/regmask.hpp line 166:
> 
>> 164:   // indefinitely with ONE bits.  Returns TRUE if mask is infinite or
>> 165:   // unbounded in size.  Returns FALSE if mask is finite size.
>> 166:   bool is_infinite() const {
> 
> "infinite" hides the fact that these unbounded bits are stack bits and not register bits, but `is_UnboundedStack` or `is_InfiniteStack` might be too verbose.  How does `is_InfStack` sound?

I like the suggestion, but should we not make it `is_infinite_stack` (current convention according to the style guide)? Or does historic conventions in `regmask.hpp` take precedence?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27215#discussion_r2343339147
PR Review Comment: https://git.openjdk.org/jdk/pull/27215#discussion_r2343345578