RFR: 8367483: C2 crash in PhaseValues::type: assert(t != nullptr) failed: must set before get - missing notification for CastX2P(SubL(x, y))

[Emanuel Peter]

On Fri, 12 Sep 2025 08:37:55 GMT, Benoît Maillard <bmaillard at openjdk.org> wrote:

>> `CastX2PNode::Ideal` optimizes cases:
>> 
>> CastX2P(AddX(x, y)) -> AddP(CastX2P(x), y)
>> CastX2P(SubL(x, y)) -> AddP(CastX2P(x), SubL(0, y))
>> 
>> 
>> But the notification code `PhaseIterGVN::add_users_of_use_to_worklist` only adds `CastX2P` to the worklist for the `AddX` and not the `SubX` cases.
>> 
>> ---------------------------------------
>> 
>> A little brag: this is the second (unrelated, i.e. non aliasing) bug that `TestAliasingFuzzer.java` found. Fuzzing access to native MemorySegment seems to trigger new/rare patterns.
>
> Looks good to me!

@benoitmaillard Thanks for the review!

@chhagedorn Thanks for the suggestions, can I have your re-approval? ;)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/27249#issuecomment-3284329031