RFR: 8367483: C2 crash in PhaseValues::type: assert(t != nullptr) failed: must set before get - missing notification for CastX2P(SubL(x, y))

[Emanuel Peter]

On Fri, 12 Sep 2025 08:37:12 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> This makes sense, but I remember that in the past similar tests (for example `test/hotspot/jtreg/compiler/c2/TestEliminateRedundantConversionSequences.java`) were simply put in `c2`. Not sure what is the policy here.
>
> Yes, indeed. We should probably move them as well at some point. And we should probably stick more to the convention to name tests "TestXYZ" to distinguish between helper classes and actual tests.

Yes. Maybe we just have to at some point move all tests around. Will hurt a bit for backports maybe. But it should be ok on the whole.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27249#discussion_r2343463923