RFR: 8367397: Improve naming and terminology in regmask.hpp and regmask.cpp [v2]
Daniel Lundén
dlunden at openjdk.org
Fri Sep 12 12:53:39 UTC 2025
On Fri, 12 Sep 2025 00:18:59 GMT, Dean Long <dlong at openjdk.org> wrote:
>> Daniel Lundén has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Lowercase _RM_INT and _RM_WORD
>
> src/hotspot/share/opto/regmask.hpp line 166:
>
>> 164: // indefinitely with ONE bits. Returns TRUE if mask is infinite or
>> 165: // unbounded in size. Returns FALSE if mask is finite size.
>> 166: bool is_infinite() const {
>
> "infinite" hides the fact that these unbounded bits are stack bits and not register bits, but `is_UnboundedStack` or `is_InfiniteStack` might be too verbose. How does `is_InfStack` sound?
OK, I've now changed it to `is_infinite_stack`. @dean-long Let us know if you feel strongly about this and want to change it. I don't think it is too verbose.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27215#discussion_r2344154909
More information about the hotspot-compiler-dev
mailing list